Add no-interpolate feature option to the CLI#1955
Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom Jan 9, 2025
Merged
Add no-interpolate feature option to the CLI#1955k8s-ci-robot merged 2 commits intokubernetes:mainfrom
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
Conversation
cdrage
requested changes
Nov 12, 2024
Member
|
/lgtm |
Member
|
/approve |
hangyan
approved these changes
Nov 30, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, hangyan, jvitor83 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM Can you address this invalid message warnning? |
0019903 to
b354989
Compare
Contributor
Author
Sorry about that. The commit message has "fixes". Have it removed! |
Contributor
Author
|
Hi @cdrage, I guess this is good to be merged! |
Member
Sorry for the delay! You are right, ready to be merged. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow the generated files to keep the environment variable placeholders in order to be interpolated in a later moment.
Which issue(s) this PR fixes:
Fixes #1953
Special notes for your reviewer:
This didn't pretend to put all compose keys to support the "env var placeholder" to not be interpolated, but the basic (most used ones) like "image" and "environments". Otherwise, it will be a huge effort to support this kind of feature. I guess each "non-supported" attribute can have it own issue and addressed as needed (as said in the #1953).