Add support for content in config#1952
Conversation
cdrage
left a comment
There was a problem hiding this comment.
This code looks amazing! Could you please update the documentation matrix as well for compatibility?
I believe we need to add another entry there. https://github.com/kubernetes/kompose/blob/main/docs/conversion.md
Otherwise, awesome code / changes and AMAZING tests. Big thanks!
|
Done as asked! |
| } | ||
| } | ||
|
|
||
| func TestCreateServiceWithConfigLongSyntax(t *testing.T) { |
There was a problem hiding this comment.
they should, looks like it passed on this PR.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, jvitor83 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5bc3ff9 to
a495420
Compare
I guess it is ok now @cdrage |
|
/lgtm |
|
@hangyan: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
Closes #1947
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added support to
contentinconfigelement.Unit test included.
Which issue(s) this PR fixes:
Fixes #1947