Skip to content

Fix issue 1942#1950

Merged
k8s-ci-robot merged 6 commits intokubernetes:mainfrom
hurzelpurzel:main
Nov 6, 2024
Merged

Fix issue 1942#1950
k8s-ci-robot merged 6 commits intokubernetes:mainfrom
hurzelpurzel:main

Conversation

@hurzelpurzel
Copy link
Copy Markdown
Contributor

@hurzelpurzel hurzelpurzel commented Oct 30, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

PVC names will now in the valid format

Which issue(s) this PR fixes:

Fixes # 1942

Special notes for your reviewer:

go.mod was changed to point to a valid openshift api version

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2024
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Oct 30, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 30, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2024

Welcome @hurzelpurzel!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 30, 2024
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Nov 6, 2024

Thank you for the fix as well as the fix with compiling / mod go 🚀 🚀 🚀 🚀 🚀 🚀

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Nov 6, 2024

This code LGTM!

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Nov 6, 2024

/lgtm

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Nov 6, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, hurzelpurzel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1ebc27a into kubernetes:main Nov 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hurzelpurzel @k8s-ci-robot @cdrage