Skip to content

feature: support UID:GID in the user key#1929

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
favonia:gid
Sep 5, 2024
Merged

feature: support UID:GID in the user key#1929
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
favonia:gid

Conversation

@favonia
Copy link
Copy Markdown
Contributor

@favonia favonia commented Aug 28, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

With this PR, Kompose can convert UID:GID to both RunAsUser and RunAsGroup. Previously, it cannot understand the :GID part.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I modified the existing test case to check uid:gid. It does not check the simpler case uid. Also, one of the file does not seem to have existing tests (?).

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Aug 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: favonia / name: favonia (0ace110)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 28, 2024

Welcome @favonia!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot requested review from TessaIO and cdrage August 28, 2024 13:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 28, 2024
@favonia favonia mentioned this pull request Aug 28, 2024
Closed
@favonia
Copy link
Copy Markdown
Contributor Author

favonia commented Aug 30, 2024

Sorry for the compilation error. It's now fixed.

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Aug 31, 2024

Sorry for the compilation error. It's now fixed.

Apologize for the delay! I am on PTO. But I'll be happy to test this Tuesday :) pleases remind me if I don't haha! This is a great feature to finally add.

@favonia
Copy link
Copy Markdown
Contributor Author

favonia commented Sep 5, 2024

@cdrage ping

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Sep 5, 2024

Tested this out and it works great!

LGTM! Once this pasts tests, it'll merge.

Thanks for the awesome contribution!!

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Sep 5, 2024

/approve

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Sep 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, favonia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 15a9212 into kubernetes:main Sep 5, 2024
@favonia favonia deleted the gid branch September 5, 2024 22:50
@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@favonia @k8s-ci-robot @cdrage