[completion] Add header #compdef#1915
Merged
cdrage merged 1 commit intokubernetes:mainfrom Sep 13, 2024
sazriel26:fix-zsh-completion
Merged
[completion] Add header #compdef#1915cdrage merged 1 commit intokubernetes:mainfrom sazriel26:fix-zsh-completion
cdrage merged 1 commit intokubernetes:mainfrom
sazriel26:fix-zsh-completion
Conversation
|
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sazriel26 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@sazriel26 can you rebase please to make the tests pass |
Contributor
Author
|
@TessaIO I gave a try to rebase, is it ok ? |
Member
|
Sorry for the late merge, LGTM now! Tested it locally and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Generation of zsh completion misses header
#compdef komposeas updated in reference:https://github.com/kubernetes/kubectl/blob/master/pkg/cmd/completion/completion.go#L174
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Not familiar with Go, but looks confident about 🤗
Since the completion is not "native" but converted from
bash, the directivecompdef <function> <command>looks not mandatory (this is the second line to append when completion is zsh-native)