Merged
Conversation
7653bd4 to
92f03ec
Compare
TessaIO
reviewed
May 30, 2024
TessaIO
reviewed
May 30, 2024
TessaIO
reviewed
May 30, 2024
Member
Author
|
@TessaIO thank you! Updated it and ready for another review. |
Member
Author
|
Failing because #1886 needs to go in |
#### What type of PR is this? <!-- Add one of the following kinds: /kind bug /kind cleanup /kind feature --> /kind documentation #### What this PR does / why we need it: Updates the user guide completely revamp it / describe each label. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Closes kubernetes#1584 Closes kubernetes#1577 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <charlie@charliedrage.com> Please check the docs examples / each label that it's okay!
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
TessaIO
approved these changes
Jun 2, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: update user guide
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates the user guide completely revamp it / describe each label.
Which issue(s) this PR fixes:
Closes #1584
Closes #1577
Closes #1576
Special notes for your reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com
Please check the docs examples / each label that it's okay!