Feature 1635 - added labels to generate HPA#1847
Merged
k8s-ci-robot merged 5 commits intokubernetes:mainfrom Apr 19, 2024
Merged
Feature 1635 - added labels to generate HPA#1847k8s-ci-robot merged 5 commits intokubernetes:mainfrom
k8s-ci-robot merged 5 commits intokubernetes:mainfrom
Conversation
kompose.hpa.minreplicas kompose.hpa.maxreplicas kompose.hpa.cpu kompose.hpa.memory documentated labels user_guide.md generate custom metrics from cpu, memory and set min/max replicas Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
cdrage
requested changes
Apr 2, 2024
Member
cdrage
left a comment
There was a problem hiding this comment.
This is amazing work, great job on the implementation!
Needs e2e and regular tests though, sorry!
e2e tests fixed name labels
…more tests add warning in situations like: - maxreplicas < minreplicas - value from label < 0 - validate percentage in cpu, memory metrics
Contributor
Author
|
done 👌 |
Member
|
ping @sosan. Can you fix merge conflicts? |
reformat k8sutils_tests.go Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
Contributor
Author
|
fixed merge conflicts |
cdrage
approved these changes
Apr 19, 2024
Member
cdrage
left a comment
There was a problem hiding this comment.
Amazing, thanks for the awesome work! All the code LGTM!
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sosan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
added this labels to min/max replicas and custom metrics for cpu and memory:
kompose.hpa.minreplicas
kompose.hpa.maxreplicas
kompose.hpa.cpu
kompose.hpa.memory
documentated labels user_guide.md
generate custom metrics from cpu, memory and set min/max replicas
Which issue(s) this PR fixes:
Fixes #1631
Special notes for your reviewer: