customize resource name individually via labels kompose.service.name_override#1837
Merged
k8s-ci-robot merged 4 commits intokubernetes:mainfrom Apr 25, 2024
Merged
Conversation
…ame_override Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
Member
|
Thanks @sosan, I would review this once the other PR is merged! |
Member
|
/approve |
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
cdrage
approved these changes
Apr 25, 2024
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sosan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
this PR is the second part from #1833 and suggests labels to allow individual customization. Uses
kompose.service.name_overridelabel, but can change label nameWhich issue(s) this PR fixes:
Feature #1635
Special notes for your reviewer:
tests
Test_parseKomposeLabelsencounters a corner case scenario where the resource name that being processed starts or ends with a hyphen '-' or any other character// This is a corner case that is expected to fail because
// it does not account for scenarios where the string
// starts or ends with a '-' or any other character
// this test will fail with current tests