Skip to content

Add Labels for CronJob https://github.com/kubernetes/kompose/issues/1795#1806

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
realgam3:cronjob
Jan 17, 2024
Merged

Add Labels for CronJob https://github.com/kubernetes/kompose/issues/1795#1806
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
realgam3:cronjob

Conversation

@realgam3
Copy link
Copy Markdown
Contributor

@realgam3 realgam3 commented Jan 16, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add CronJob Labels:

  • kompose.controller.type: cronjob
    • kompose.cronjob.schedule: "5 4 * * *"
    • kompose.cronjob.concurrency_policy: (Allow|Forbid|Replace)

Which issue(s) this PR fixes:

Feature #1795

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2024
@k8s-ci-robot k8s-ci-robot requested review from ngtuna and sebgoa January 16, 2024 21:48
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2024
@realgam3
Copy link
Copy Markdown
Contributor Author

realgam3 commented Jan 16, 2024

@AhmedGrati @cdrage
Because of the many conflicts I've decided to create a new Pull request,

I hope it's ok with you...

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jan 16, 2024

@AhmedGrati @cdrage Because of the many conflicts I've decided to create a new Pull request,

I hope it's ok with you...

Fine by me!

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jan 16, 2024

@AhmedGrati @cdrage Because of the many conflicts I've decided to create a new Pull request,
I hope it's ok with you...

Fine by me!

I'll go through the code once all the tests have pass & I have a bit of time tonight :)

@realgam3
Copy link
Copy Markdown
Contributor Author

realgam3 commented Jan 16, 2024 •
edited
Loading

Thank you ❤️
I saw you removed the example files, so I removed mine as well...

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jan 17, 2024

/lgtm

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jan 17, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, realgam3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Jan 17, 2024

Approving and LGTM since this has been throughly reviewed a few times! Thanks for the awesome new feature!

I'll push a new release this week so this is out :)

@realgam3
Copy link
Copy Markdown
Contributor Author

realgam3 commented Jan 17, 2024

Thank you!
It was fun working with you.

@k8s-ci-robot k8s-ci-robot merged commit f11ce54 into kubernetes:main Jan 17, 2024
@Porkepix Porkepix mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngtuna ngtuna Awaiting requested review from ngtuna

@sebgoa sebgoa Awaiting requested review from sebgoa

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@realgam3 @cdrage @k8s-ci-robot