Skip to content

Removed fedora installation instruction from installation.md#1774

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
utkarsh-singh1:update-docs-installation-md
Dec 4, 2023
Merged

Removed fedora installation instruction from installation.md#1774
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
utkarsh-singh1:update-docs-installation-md

Conversation

@utkarsh-singh1
Copy link
Copy Markdown
Contributor

@utkarsh-singh1 utkarsh-singh1 commented Dec 4, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Installation instruction for linux, it can Also be installed with brew or using go install method.

Which issue(s) this PR fixes:

Fixes # 1773

Special notes for your reviewer:

@utkarsh-singh1
Removed fedora installation instruction from installation.md
9ecf2f9 
Signed-off-by: utkarsh-singh1 <utkarsh.singh1@india.nec.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 4, 2023

Welcome @utkarsh-singh1!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@utkarsh-singh1
Copy link
Copy Markdown
Contributor Author

utkarsh-singh1 commented Dec 4, 2023

Also, seems like the package is not updated for a long time - https://github.com/dustymabe/fedpkg-kompose

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Dec 4, 2023

/lgtm

@cdrage
Copy link
Copy Markdown
Member

cdrage commented Dec 4, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, utkarsh-singh1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit af06917 into kubernetes:main Dec 4, 2023
@utkarsh-singh1
Copy link
Copy Markdown
Contributor Author

utkarsh-singh1 commented Dec 7, 2023

Thanks, @cdrage, for approval.

Fixes #1773

@Porkepix Porkepix mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage cdrage approved these changes

@AhmedGrati AhmedGrati Awaiting requested review from AhmedGrati

@hangyan hangyan Awaiting requested review from hangyan

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@utkarsh-singh1 @k8s-ci-robot @cdrage