bug: fixes bug with error out with using kompose convert with no -f#1725
Merged
cdrage merged 1 commit intokubernetes:mainfrom Oct 6, 2023
Merged
bug: fixes bug with error out with using kompose convert with no -f#1725cdrage merged 1 commit intokubernetes:mainfrom
cdrage merged 1 commit intokubernetes:mainfrom
Conversation
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug Fixes a validation bug where if you do not provide a compose.yaml or docker-compose.yaml it will nil point error out rather than have an appropriate "file not found" output. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Closes kubernetes#1719 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/lgtm |
Contributor
|
@cdrage: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: fixes bug with error out with using kompose convert with no -f
What type of PR is this?
/kind bug
Fixes a validation bug where if you do not provide a compose.yaml or
docker-compose.yaml it will nil point error out rather than have an
appropriate "file not found" output.
It was also going through the list of valid files (compose.yaml, compose.yml), |
but only failing after the first one wasn't found..
So if someone had a docker-compose.yaml file, it'd fail.
Which issue(s) this PR fixes:
Closes #1719
Special notes for your reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com