Skip to content

Compose env_file should result in a envFrom in deployment #1999

@robertaistleitner

Description

@robertaistleitner

What would you like to be added?

I want env_file entries in Docker Compose to result in envFrom entries in the Deployment instead of single entries using configMapKeyRef in env.

Why is this needed?

At the moment a env_file is properly converted to a ConfigMap which is nice and all the contained environment variables are then added to containers env using configMapKeyRefs. I think this is overcomplicating the deployment file since one could simply use envFrom and load the full ConfigMap to the container envs.

This should look like this:

envFrom:
    - configMapRef:
        name: example-env

Is there anything I didn't think of which could prevent this change?

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions