Skip to content

Change label names, get rid of dashes. #1881

@cdrage

Description

@cdrage

What would you like to be added?

Our labels are a bit of a mess at the moment as they do not follow a simple convention.

It should be: kompose....

For example, this is good: kompose.service.healthcheck.readiness.test

However, this is something that needs to be changed: kompose.service.expose.tls-secret should be kompose.service.tls-secret.expose since it follows the type, second type, action scenario.

The following labels should be changed:

  • kompose.service.expose.tls-secret should be kompose.service.tls_secret
  • kompose.service.expose.ingress-class-name should be kompose.service.ingress_class_name
  • kompose.image-pull-policy should be kompose.image.pull_policy
  • kompose.image-pull-secret should be kompose.image.pull_secret
  • kompose.service.external-traffic-policy should be kompose.service.external_traffic_policy
  • kompose.security-context.fsgroup should be kompose.security_context.fsgroup

Why is this needed?

FYI This MUST be backwards compatible. We should add these updates to the label, but also adhere to the old labels (in case people have been using them)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions