forked from golang/glog
-
Notifications
You must be signed in to change notification settings - Fork 228
textlogger: don't leak internal VState in the Config API #367
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
/kind bug
What steps did you take and what happened:
Config embeds VState, which makes VState methods V and VModule accessible. This was intentional because it enables verbosity level changes at runtime. However, it's not a good solution because the internal packages should be completely hidden.
What did you expect to happen:
Config should define its own API for v and vmodule changes. This might even be the same as in VState.
Advantages:
- more discoverable
- proper layering
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.