forked from golang/glog
-
Notifications
You must be signed in to change notification settings - Fork 227
restore dropping large buffers #364
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Type
Fields
Give feedbackNo fields configured for issues without a type.
/kind bug
What steps did you take and what happened:
buffers.PutBuffer used to discard buffers larger than 256 bytes. That got dropped as an unnecessary safeguard, but was called out again as something that might be useful in kubernetes/kubernetes#115277 (review)
What did you expect to happen:
PutBuffer should simply ignore buffers larger than 256 bytes and let the garbage collector free them.
/assign