Skip to content

AWS: Add private subnets the kOps CI cluster#8635

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
hakman:kops-eks-additional-subnets
Oct 13, 2025
Merged

AWS: Add private subnets the kOps CI cluster#8635
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
hakman:kops-eks-additional-subnets

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Oct 12, 2025

This should give us 4x more IPs for the kOps EKS cluster.

/cc @ameukam @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 12, 2025
@k8s-infra-ci-robot
Copy link
Copy Markdown
Contributor

k8s-infra-ci-robot commented Oct 12, 2025

Ran Plan for dir: infra/aws/terraform/kops-infra-ci workspace: default

Plan Error

Show Output 
running 'sh -c' '/atlantis/bin/terraform1.5.7 init -input=false -upgrade' in '/atlantis/repos/kubernetes/k8s.io/8635/default/infra/aws/terraform/kops-infra-ci': exit status 1

Initializing the backend...
Upgrading modules...
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 5.60.0 for ci_iam_group...
- ci_iam_group in .terraform/modules/ci_iam_group/modules/iam-group-with-policies
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 5.60.0 for cluster_autoscaler_irsa_role...
- cluster_autoscaler_irsa_role in .terraform/modules/cluster_autoscaler_irsa_role/modules/iam-role-for-service-accounts-eks
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 5.60.0 for ebs_csi_irsa...
- ebs_csi_irsa in .terraform/modules/ebs_csi_irsa/modules/iam-role-for-service-accounts-eks
Downloading registry.terraform.io/terraform-aws-modules/eks/aws 20.37.2 for eks...
- eks in .terraform/modules/eks
- eks.eks_managed_node_group in .terraform/modules/eks/modules/eks-managed-node-group
- eks.eks_managed_node_group.user_data in .terraform/modules/eks/modules/_user_data
- eks.fargate_profile in .terraform/modules/eks/modules/fargate-profile
Downloading registry.terraform.io/terraform-aws-modules/kms/aws 2.1.0 for eks.kms...
- eks.kms in .terraform/modules/eks.kms
- eks.self_managed_node_group in .terraform/modules/eks/modules/self-managed-node-group
- eks.self_managed_node_group.user_data in .terraform/modules/eks/modules/_user_data
Downloading registry.terraform.io/terraform-aws-modules/eks/aws 20.37.2 for eks-auth...
- eks-auth in .terraform/modules/eks-auth/modules/aws-auth
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 5.60.0 for kops_ci_user...
- kops_ci_user in .terraform/modules/kops_ci_user/modules/iam-user
Downloading registry.terraform.io/terraform-aws-modules/vpc/aws 5.21.0 for vpc...
- vpc in .terraform/modules/vpc
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 5.60.0 for vpc_cni_irsa...
- vpc_cni_irsa in .terraform/modules/vpc_cni_irsa/modules/iam-role-for-service-accounts-eks
Downloading registry.terraform.io/terraform-aws-modules/vpc/aws 5.21.0 for vpc_endpoints...
- vpc_endpoints in .terraform/modules/vpc_endpoints/modules/vpc-endpoints
╷
│ Error: error configuring S3 Backend: no valid credential sources for S3 Backend found.
│ 
│ Please see https://www.terraform.io/docs/language/settings/backends/s3.html
│ for more information about providing credentials.
│ 
│ Error: NoCredentialProviders: no valid providers in chain. Deprecated.
│ 	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
│ 
│ 
│ 
╵

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 12, 2025

/override "atlantis/plan"
/override "atlantis/plan: infra/aws/terraform/kops-infra-ci/default"

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2025

@hakman: Overrode contexts on behalf of hakman: atlantis/plan, atlantis/plan: infra/aws/terraform/kops-infra-ci/default

Details

In response to this:

/override "atlantis/plan"
/override "atlantis/plan: infra/aws/terraform/kops-infra-ci/default"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman hakman mentioned this pull request Oct 12, 2025
Merged
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Oct 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit f7d330a into kubernetes:main Oct 13, 2025
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 13, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Oct 13, 2025

@hakman actuated

@hakman hakman deleted the kops-eks-additional-subnets branch October 13, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

4 participants

@hakman @k8s-ci-robot @k8s-infra-ci-robot @ameukam