There is now a easier solution to create TLS certs.#176
Merged
ahmetb merged 3 commits intokubernetes:masterfrom Jan 18, 2018
Merged
There is now a easier solution to create TLS certs.#176ahmetb merged 3 commits intokubernetes:masterfrom
ahmetb merged 3 commits intokubernetes:masterfrom
Conversation
ahmetb
reviewed
Jan 18, 2018
| First generate a self signed rsa key and certificate that the server can use for TLS. | ||
|
|
||
| ```sh | ||
| $ make keys secret KEY=/tmp/nginx.key CERT=/tmp/nginx.crt SECRET=/tmp/secret.json |
Member
There was a problem hiding this comment.
do you perhaps need to remove the keys target from the makefile now?
Contributor
Author
There was a problem hiding this comment.
you are right, I pushed a new commit that improves my change
ahmetb
reviewed
Jan 18, 2018
staging/https-nginx/README.md
Outdated
|
|
||
| ```sh | ||
| $ make keys secret KEY=/tmp/nginx.key CERT=/tmp/nginx.crt SECRET=/tmp/secret.json | ||
| $ openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout /tmp/nginx.key -out /tmp/nginx.crt -subj "/CN=nginxsvc/O=nginxsvc" |
Member
There was a problem hiding this comment.
I'm not sure why you’re changing this part. I think make keys is still valid, you just need to delete make_secret.go (and the secret: target from Makefile) and the kubectl create command below.
Contributor
Author
There was a problem hiding this comment.
You are right. I can keep the makefile for the keys generation. Look at my latest commit. Thank you
Member
|
Looks good. Can you remove the |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#14017