Skip to content

Update KEP template#690

Closed
pwittrock wants to merge 1 commit intokubernetes:masterfrom
pwittrock:kep
Closed

Update KEP template#690
pwittrock wants to merge 1 commit intokubernetes:masterfrom
pwittrock:kep

Conversation

@pwittrock
Copy link
Copy Markdown
Member

@pwittrock pwittrock commented Jan 15, 2019

  • Add release checklist
  • Expand upon graduation criteria
  • Add test plan section
  • Add upgrade / downgrade section
  • Add version skew section

@pwittrock
Update KEP template
ca40f35 
- Add release checklist
- Expand upon graduation criteria
- Add test plan section
- Add upgrade / downgrade section
- Add version skew section
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot requested a review from jbeda January 15, 2019 23:05
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/pm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2019
@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 15, 2019

/assign @spiffxp

@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 15, 2019

/assign @justaugustus

@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 15, 2019

cc @kubernetes/sig-release

@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 15, 2019

cc @kubernetes/sig-contributor-experience-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Jan 15, 2019
@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 15, 2019

/assign @calebamiles

@spiffxp spiffxp mentioned this pull request Jan 17, 2019
Merged
@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 17, 2019

/ping

@pwittrock pwittrock closed this Jan 19, 2019
@pwittrock
Copy link
Copy Markdown
Member Author

pwittrock commented Jan 19, 2019

closing per discussion with @calebamiles

@calebamiles
Copy link
Copy Markdown
Contributor

calebamiles commented Jan 19, 2019

/reopen
/approve

My mistake. We agreed in SIG Arch to iterate on this content on the PR. I'm personally of the opinion that we should wait until the next release for these requirements but I defer to the wisdom of the Release Team Lead.

@k8s-ci-robot k8s-ci-robot reopened this Jan 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 19, 2019

@calebamiles: Reopened this PR.

Details

In response to this:

/reopen
/approve

My mistake. We agreed in SIG Arch to iterate on this content on the PR. I'm personally of the opinion that we should wait until the next release for these requirements but I defer to the wisdom of the Release Team Lead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 19, 2019

/hold
I would like to make sure we've had sufficient discussion and review on both the content, and the impacts of this as it pertains to the use of https://github.com/calebamiles/keps/tree/master/helpers/convert

(ref: #619 and kubernetes/community#2725)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2019
@justaugustus justaugustus mentioned this pull request Jan 19, 2019
Merged
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jan 19, 2019

Closing in favor of #703 (so I can carry the PR updates, instead of @pwittrock).
/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 19, 2019

@justaugustus: Closed this PR.

Details

In response to this:

Closing in favor of #703 (so I can carry the PR updates, instead of @pwittrock).
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebamiles calebamiles Awaiting requested review from calebamiles

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@calebamiles calebamiles

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pwittrock @calebamiles @k8s-ci-robot @spiffxp @justaugustus