Removing dockershim from kubelet#1985
Conversation
1299e13 to
f37c573
Compare
|
/hold for review |
f37c573 to
5c76548
Compare
odinuge
left a comment
There was a problem hiding this comment.
Thanks for working on this @dims (and @mattjmcnaughton)! I agree on the overall idea as discussed previously, and as a sig-node contributor it would also make "my life" a lot easier. It would also help making the codebase cleaner and easier to work with. 😄
Still need to read through and think about the details, but overall this looks good!
| - flags that are used to configure dockershim. | ||
| - support to get container logs when docker uses journald as the driver. | ||
| - logic of moving docker processes to a given cgroup | ||
| - TBD anything else? |
|
Thanks for your thought and leadership on this project @dims and @derekwaynecarr :) |
|
/cc @SergeyKanzhelev |
5c76548 to
1ab0605
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
1ab0605 to
2b5ccee
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
| Target releases: 1.22 | ||
|
|
||
| Actions: | ||
| - Document and announce migration guide. |
There was a problem hiding this comment.
is there a tracking issue for this migration guide, i think it would help to include in it what steps do existing users take for moving from docker to containerd running on there hosts ?
Signed-off-by: Davanum Srinivas davanum@gmail.com