Update exec credential provider KEP with feedback from cluster info PR#1927
Conversation
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
|
Hi @ankeesler. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@liggitt - do you have time/willingness to take a look at this this week? |
|
apologies, this got lost in 1.19 closing / 1.20 reopening... let's set up a time to talk through the changes over VC, that'll be probably be faster. I'll reach out to work out a time |
| certificate-authority: "/etc/kubernetes/ca.pem" | ||
| extensions: | ||
| - name: exec # reserved extension name for per cluster exec config | ||
| - name: client.authentication.k8s.io/exec # reserved extension name for per cluster exec config |
| // ProxyURL is the URL to the proxy to be used for all requests to this | ||
| // cluster. | ||
| // +optional | ||
| ProxyURL string `json:"proxy-url,omitempty"` |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankeesler, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrew Keesler akeesler@vmware.com
ProxyURL)client.authentication.k8s.io/exec)@liggitt - would you be willing to submit your opinion about these updates? I reach out to you because you and @enj discussed a proper superset of these changes in kubernetes/kubernetes#91192. I understand this is not the whole set of changes that you requested in that PR, but I tried to take the intersection of you and @enj's proposals and present them here as a starting place. My hope is that we can 1) tie off the cluster info design in this KEP, 2) update the implementation, 3) get the implementation approved, and 4) get the implementation merged.