Runtimeclass scheduling updates#1069
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom May 31, 2019
Merged
Conversation
yastij
approved these changes
May 20, 2019
Member
yastij
left a comment
There was a problem hiding this comment.
/lgtm
As we can still express constrains using nodeSelector and tolerations
Member
|
Thanks! /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: tallclair, thockin, yastij The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups from the RuntimeClass scheduling API / architecture review. Concerns raised in the review:
Topologyis too ambiguous and overloadedThis update addresses those concerns by:
TopologytoSchedulingcorev1.NodeSelectortype withmap[string]string. This makes the merging logic much simpler, so we can mix in the node selector in admission and leave the scheduler untouched. If we find a need for the more complicated node selector logic in the future, we can revisit this decision with an additional field./assign @thockin @dchen1107 @bsalamat @yastij
/sig node
/milestone v1.15
/priority important-soon