Welcome @zhangguanzhang!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @zhangguanzhang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhangguanzhang
Once this PR has been reviewed and has the lgtm label, please assign mrhohn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/ok-to-test

/retest

/test pull-kubernetes-dns-test

Hi @zhangguanzhang
When are you targeting to merge this fix. We are using this package in one of the app container which is flagging GHSA-hq6q-c2x6-hmch findings.
Thanks

Hi @zhangguanzhang When are you targeting to merge this fix. We are using this package in one of the app container which is flagging GHSA-hq6q-c2x6-hmch findings. Thanks

CI unit tests fail, the error information is not detailed enough, and no developer follows up on the issue

@zhangguanzhang You are the PR author, so it is expected that you would investigate a test failing on it. I see the test failed three times on July 23rd, July 29th, and September 14th with the exact same error message

Running Suite: k8s-dns e2e test suite
=====================================
Random Seed: 1721761545
Will run 5 of 5 specs
2024/07/23 19:06:06 exit status 1
Ginkgo ran 1 suite in 20.388274658s
Test Suite Failed

so it does not look like test flakiness.

/retest

@zhangguanzhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@zhangguanzhang You are the PR author, so it is expected that you would investigate a test failing on it. I see the test failed three times on July 23rd, July 29th, and September 14th with the exact same error message

Running Suite: k8s-dns e2e test suite
=====================================
Random Seed: 1721761545
Will run 5 of 5 specs
2024/07/23 19:06:06 exit status 1
Ginkgo ran 1 suite in 20.388274658s
Test Suite Failed

so it does not look like test flakiness.

The error message from CI is not detailed enough, and I don't have a clue how to troubleshoot it.

It turns out that this test fails identically for an empty PR, so there is something wrong with tests, and this PR may be perfectly correct. I opened issue #646.

Hi @DamianSawicki @zhangguanzhang
Is there any ETA when this fix will be merged or any ticket that we can track for the fix deployment.
Thanks

Hey @VikashLNU. This is a community OSS repository, so neither zhangguanzhang nor I are responsible for it. As I wrote above, this is blocked by #646. I've just pinged there one person that may hopefully be able to help. If you are interested in expediting this, perhaps you can escalate with the Network SIG, e.g. on slack.

PR needs rebase.

This has been superseded by #649