WIP: Make manifest lists of the dns images#30
WIP: Make manifest lists of the dns images#30luxas wants to merge 1 commit intokubernetes:masterfrom
Conversation
…ybox to minimize the delta between amd64 and non-amd64
|
cc @MrHohn also |
| @docker push $(REGISTRY)/$(IMAGENAME)-$(ARCH):$(VERSION) | ||
| @cat $< > $@ | ||
|
|
||
| .PHONY: clean |
There was a problem hiding this comment.
add manifest-tool to clean and any other generated file (I think .emptydir is created as well)
| chmod +x manifest-tool | ||
|
|
||
| gcr-login: | ||
| ifeq ($(findstring gcr.io,$(PREFIX)),gcr.io) |
| @ARCH=$(ARCH) IMAGE=$(REGISTRY)/$(IMAGENAME)-$(ARCH):$(VERSION) ./validate.sh | ||
|
|
||
| ./manifest-tool: | ||
| curl -sSL https://github.com/luxas/manifest-tool/releases/download/v0.3.0/manifest-tool > manifest-tool |
There was a problem hiding this comment.
What does manifest-tool do? Is it essential for the build process. I would prefer to minimize external dependencies (e.g. things that need to be downloaded) for the build.
There was a problem hiding this comment.
Looks like this is a library that creates multi-os docker manifest files.
| MAINTAINER Bowei Du <bowei@google.com> | ||
|
|
||
| ADD bin/ARG_ARCH/ARG_BIN /ARG_BIN | ||
| USER nobody:nogroup |
There was a problem hiding this comment.
will this work? DNS wants to bind to :53 which is < 1024
There was a problem hiding this comment.
oh, didn't think about that, just harmonized the Dockerfiles automatically, will fix
|
I would love an equivalent changeset to https://github.com/thockin/go-build-template :) |
| ifeq ($(ARCH),amd64) | ||
| BASEIMAGE ?= alpine:3.4 | ||
| COMPILE_IMAGE := alpine:3.4 | ||
| BASEIMAGE ?= busybox:glibc |
There was a problem hiding this comment.
Does this build correctly? I believe we add several packages with apk. Is apk present in busybox:glibc?
|
Is this still valid? |
|
@cmluciano I wish it was merged long time ago, but it's still pending due to that gcr.io doesn't support v2 schema 2 (-> no manifest lists can be pushed) :( |
|
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
|
/remove-lifecycle stale @mkumatag is looking into this now that we're unblocked... |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Closing this as it's out of date and we're targeting that CoreDNS will get this functionality instead |
... and base everything on busybox to minimize the delta between amd64 and non-amd64 images
Also I tried to make the Makefiles simpler, let me know what you think @bowei and others!
A manifest list is an image that's kind of a placeholder for other arch-specific images, so basically if we have
k8s-dns-dnsmasq:versionin a manifest and are using docker; docker will fetch the right-archversion for us automatically!Tested it locally, and it seems like I got it working. I also added s390x to the list