Skip to content

Localize contributor cheatsheet in Korean#3660

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiajkang:ko-contributor-cheatsheet
May 6, 2019
Merged

Localize contributor cheatsheet in Korean#3660
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
claudiajkang:ko-contributor-cheatsheet

Conversation

@claudiajkang
Copy link
Copy Markdown
Contributor

@claudiajkang claudiajkang commented Apr 30, 2019 •
edited
Loading

This commit fixed kubernetes/website#13989 kubernetes/website#13991.

/cc @kubernetes/sig-docs-ko-owners
/cc @kubernetes/sig-docs-ko-reviews
/cc @chenrui333

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 30, 2019

Welcome @claudiajkang!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Apr 30, 2019
@claudiajkang claudiajkang force-pushed the ko-contributor-cheatsheet branch from 1e086ab to 4ad6931 Compare April 30, 2019 17:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 30, 2019
@claudiajkang claudiajkang force-pushed the ko-contributor-cheatsheet branch 3 times, most recently from 2efff05 to 8e3a963 Compare April 30, 2019 17:42
@claudiajkang claudiajkang mentioned this pull request Apr 30, 2019
Closed
@mrbobbytables
Copy link
Copy Markdown
Member

mrbobbytables commented May 1, 2019

Thanks so much for adding the Korean translation @claudiajkang ! :D
Really appreciate your efforts :)

ianychoi
ianychoi suggested changes May 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Please see my reviews, and I would like to request some changes + your kind opinions from my suggestion and/or idea.

With many thanks,

/Ian

@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented May 1, 2019 •
edited
Loading

@ianychoi Thank you! I will apply your comments right away.

ianychoi
ianychoi suggested changes May 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better - Please reflect minor postpositional particle (조사) after changing a few words.

@claudiajkang claudiajkang force-pushed the ko-contributor-cheatsheet branch 2 times, most recently from 4419b29 to 1490331 Compare May 3, 2019 15:16
@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented May 3, 2019

@ianychoi Thank you for the review. Updated the content.

@ianychoi
Copy link
Copy Markdown
Member

ianychoi commented May 4, 2019

Thank u - lgtm as one of @kubernetes/sig-docs-ko-reviews

@cblecker
Copy link
Copy Markdown
Member

cblecker commented May 4, 2019

Thank you @claudiajkang for writing this, and @ianychoi for reviewing!

@claudiajkang are you able to swash this into one commit? Then I'll approve this for merge.

@claudiajkang
Localize contributor cheatsheet in Korean
955e91a 
* This commit add Korean contributor cheatsheet.

* Apply ianychoi's comment
@claudiajkang claudiajkang force-pushed the ko-contributor-cheatsheet branch from 1490331 to 955e91a Compare May 6, 2019 05:45
@claudiajkang
Copy link
Copy Markdown
Contributor Author

claudiajkang commented May 6, 2019

@ianychoi Thank you!

@cblecker I changed to one commit. Could you check this PR?

@cblecker
Copy link
Copy Markdown
Member

cblecker commented May 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit fa149ea into kubernetes:master May 6, 2019
@mrbobbytables mrbobbytables mentioned this pull request May 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ianychoi ianychoi ianychoi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Epic] Contributor cheatsheet localization

5 participants

@claudiajkang @k8s-ci-robot @mrbobbytables @ianychoi @cblecker