Skip to content

Update localization subproject info#2753

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zacharysarah:consolidate-l10n-subprojects
Oct 15, 2018
Merged

Update localization subproject info#2753
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zacharysarah:consolidate-l10n-subprojects

Conversation

@zacharysarah
Copy link
Copy Markdown
Contributor

@zacharysarah zacharysarah commented Oct 5, 2018 •
edited
Loading

This PR updates subproject info for SIG Docs. Specifically, it removes reference to kubernetes-docs-** repositories, which are slated for archival pending approval/merge of kubernetes/website#10485.

This PR goes stale on Friday, October 19. Feel free to close this PR if it's still open on or after October 19, 2018.

Dependencies

PR Description ✔️
kubernetes/website#10485 Update localization guidelines and workflows
kubernetes/org#154 Archive localization repos

/sig docs

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2018
@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 5, 2018 •
edited
Loading

UPDATE: Fixed!

I see this error and will update the PR and description accordingly:

I1005 00:35:17.989] ====================================================================
I1005 00:35:17.989] 1 mismatches were detected.
I1005 00:35:17.989] Do not manually edit sig-list.md or README.md files inside the sig folders.
I1005 00:35:17.989] Instead make your changes to sigs.yaml, then run `make`, and then
I1005 00:35:17.989] commit your changes to sigs.yaml and any generated docs.
I1005 00:35:17.989] ====================================================================

@zacharysarah zacharysarah mentioned this pull request Oct 7, 2018
Merged
31 tasks
Update localization subproject info
59cbca0 
Make updates to sigs.yaml

Commit output from make
@zacharysarah zacharysarah force-pushed the consolidate-l10n-subprojects branch from 75c7c4e to 59cbca0 Compare October 8, 2018 21:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2018
@zacharysarah zacharysarah mentioned this pull request Oct 8, 2018
Closed
@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 8, 2018

This PR includes changes proposed in #2751. To avoid merge conflicts and/or the need to rebase, I recommend closing that PR in favor of this one.

/cc @Bradamant3

@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 8, 2018 •
edited
Loading

/hold
Waiting for dependencies to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2018
@zacharysarah zacharysarah changed the title [WIP] Update localization subproject info Update localization subproject info Oct 8, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2018
@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 12, 2018

@cblecker 👋 kubernetes/website#10485 has merged.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Oct 12, 2018

/approve

leaving LGTM for a sig-docs lead :)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@zacharysarah
Copy link
Copy Markdown
Contributor Author

zacharysarah commented Oct 12, 2018

/assign @chenopis

@Bradamant3
Copy link
Copy Markdown

Bradamant3 commented Oct 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4655e29 into kubernetes:master Oct 15, 2018
@zacharysarah zacharysarah deleted the consolidate-l10n-subprojects branch October 15, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenopis chenopis Awaiting requested review from chenopis

@jaredbhatti jaredbhatti Awaiting requested review from jaredbhatti

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

Assignees

@Bradamant3 Bradamant3

@chenopis chenopis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zacharysarah @cblecker @k8s-ci-robot @Bradamant3 @chenopis