Skip to content

explicitly reserve kube- prefix for system namespaces#2379

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mtaufen:kube-namespace-prefix
Jul 18, 2018
Merged

explicitly reserve kube- prefix for system namespaces#2379
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mtaufen:kube-namespace-prefix

Conversation

@mtaufen
Copy link
Copy Markdown
Contributor

@mtaufen mtaufen commented Jul 17, 2018

Based on an offline discussion with @bgrant0607, this is the existing convention and we should stick to it for any new system namespaces, and we can't use the *.k8s.io pattern, because additional dots can mess up the format for service DNS entries.

Users should absolutely not be using the kube- prefix for non-system namespaces.

/cc @bgrant0607 @liggitt

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2018
called `Fooable`, not `IsFooable`.

### Namespace Names
* The name of a namespace must be DNS compatible.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks

@mtaufen mtaufen force-pushed the kube-namespace-prefix branch from c919f78 to 4a8ea25 Compare July 18, 2018 14:12
@bgrant0607
Copy link
Copy Markdown
Member

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8f278c6 into kubernetes:master Jul 18, 2018
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jul 18, 2018

I think this is necessary, and has previously been done by convention piece-mill. Good to see it codified.

This is worth communicating to dev/user lists, since it can affect what namespaces people choose for their own projects, and how cluster deployers choose to shape custom policies.

@bgrant0607
Copy link
Copy Markdown
Member

If we want a prefix reserved for providers, I'd be open to do that. Perhaps something like kube-x-.

@thockin
Copy link
Copy Markdown
Member

thockin commented Jul 27, 2018

This is a weird doc to document this in...

@mtaufen
Copy link
Copy Markdown
Contributor Author

mtaufen commented Jul 28, 2018

@thockin do you have a better suggestion?

@thockin
Copy link
Copy Markdown
Member

thockin commented Jul 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants