Describe new labels in triage guidelines#1970
Conversation
|
/hold |
|
@cblecker thanks and I am good with hold but I thought we can use labels as such too i.e. use in combination with /close command. Org members can use these label followed by /close command to actually close the issue. Non-org members can not use close (or related) command but they can at least label trivial issues with their findings, and org member can close those issues quickly. |
|
@spzala The only way to apply these labels is to have write access to the repo. There is no prow command to add them. We need to figure out the flow, and what we are trying to do. Are we trying to allow anyone to triage issues? Do we know if we have incentives for non-org members to triage issues? Or are these labels to track statistics on issues (how many duplicates, etc) There's some confusion about the process, and we need to get it cleared up. |
|
@cblecker thanks, and good questions. Based on PR, kubernetes/test-infra#7200, I thought these labels can be applied now. I was traveling lately so unfortunately didn't get to use them yet. So below:
Do we know if we have incentives for non-org members to triage issues?
Or are these labels to track statistics on issues (how many duplicates, etc)
Thanks!! |
|
Why is kind-support a kind, and not a close? |
|
@jberkus yup good point, we considered that in the proposal with either new labels have kind or close prefix..the consensus was to go with close which definitely made more sense considering the label types. As I work with @spiffxp on changing close to triage (or related) prefix, I will discuss the legacy kind/support naming with him as it's been used for triage. Thanks! |
|
Yeah, I would support a more broad "triage/*" series of labels.. like "triage/duplicate" or "triage/support-request" |
Recently we have added new labels to identify issues that are candidates for close. These issues are typically the one which are not goint to close via a fix. Add description in triage guidelines about when to use these labels. Related PR is, kubernetes/test-infra#7554
cblecker
left a comment
There was a problem hiding this comment.
This works for me, although it might be advisable to point them to the /triage command somewhere, or provide examples.
| is clearly abandoned or in the wrong place, it should be closed. Keep in mind that | ||
| only issue reporter, assignees and component organization members can close issue. | ||
| from people who need help configuring some aspect of Kubernetes. These issues should be | ||
| labeled with `kind/support`, directed to our support structures (see below) and then closed. Also, if the issue |
There was a problem hiding this comment.
nit: this doc is wrapped at 80 chars, but this line exceeds.
| * `triage/duplicate` | ||
| * `triage/not-reproducible` | ||
| * `triage/needs-information` | ||
| * `triage/unresolved` |
There was a problem hiding this comment.
I don't see anything describing the use for this label
There was a problem hiding this comment.
Sure I will add brief explanation here.
Recently we have added new labels to identify issues that are candidates for close. These issues are typically the one which are not goint to close via a fix. Add description in triage guidelines about when to use these labels. Related PR is, kubernetes/test-infra#7554
|
/lgtm @spzala Feel free to remove hold when you're ready for this to merge. I don't know if anyone else wants to review this as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cblecker thanks!! The PR been open for review for some time now and we have discussed it in the ContribEx meeting so I am feeling safe to merge it. Also once it merge I can send email to ML about these changes we made from close/* to triage/* as we discussed earlier and can also use it at KubeCon if we end up having triage session at contributor summit. |
|
/hold cancel |
Recently we have added new labels to identify issues that are candidates for close.
These issues are typically the one which are not goint to close via a fix. Add
description in triage guidelines about when to use these labels.
Related PR is,
kubernetes/test-infra#7200