Skip to content

Outside collaborator role added#1330

Closed
idvoretskyi wants to merge 1 commit intomasterfrom
idvoretskyi-patch-1
Closed

Outside collaborator role added#1330
idvoretskyi wants to merge 1 commit intomasterfrom
idvoretskyi-patch-1

Conversation

@idvoretskyi
Copy link
Copy Markdown
Member

Added and defined the "outside collaborator" role.

Added and defined the "outside collaborator" role to the table.
@idvoretskyi idvoretskyi added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Nov 3, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2017
@idvoretskyi
Copy link
Copy Markdown
Member Author

cc @kubernetes/sig-contributor-experience-pr-reviews

Comment thread community-membership.md

| Role | Responsibilities | Requirements | Defined by |
| -----| ---------------- | ------------ | -------|
| outside collaborator | new active contributor to the community | sponsored by 1 member. existing contributions to the project. | Kubernetes GitHub org member. |
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined by: read-only collaborator on a repository in the kubernetes org

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Nov 3, 2017

How many people do we have that are collaborators vs. members?

My concern with putting this in the table is it might imply to someone that this is a required step in the ladder. I would much prefer people just jump straight to member, than think they have to go through this first. Managing collaborators is noisier.

@cblecker
Copy link
Copy Markdown
Member

cblecker commented Nov 9, 2017

+1 to @spiffxp's comments.

What does being an outside collaborator get you? Assigned issues, sure. Do we know which bot commands are gated by collaborators and which ones use IsMember? It looks like a collaborator may be able to LGTM things (https://github.com/kubernetes/test-infra/blob/7596869f74ce8cc76e5a6bcad84c3723911b29a5/prow/plugins/lgtm/lgtm.go#L91)?

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Nov 9, 2017

Collaborators can do all the things a member can do... but only for the repos they're specifically collaborators on, vs repos in the entire org. This means you could eg: give someone /lgtm privileges on kubernetes/charts without giving them /lgtm privileges on kubernetes/kubernetes

@idvoretskyi
Copy link
Copy Markdown
Member Author

@spiffxp the reason why I've added this role to the table - as we already have this role defined below - https://github.com/kubernetes/community/blob/58a1ba55effe150b4f5f1e2d770f86ef3041ffd8/community-membership.md#new-contributors.

If you feel that we shouldn't define the "collaborator" role in a table, I'd remove it from the entire document/reformat the document to follow the consistency.

@k8s-github-robot
Copy link
Copy Markdown

This PR hasn't been active in 30 days. It will be closed in 59 days (Feb 11, 2018).

cc @calebamiles @grodrigues3 @idvoretskyi

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@idvoretskyi
Copy link
Copy Markdown
Member Author

@spiffxp @calebamiles any final decision on this?

I'd like to have it merged or closed, whatever will be decided (but not to keep it open forever).

@cblecker
Copy link
Copy Markdown
Member

IIRC, this was talked about briefly at the last contribex meeting, and most who commented were not in favour of introducing another level.

@idvoretskyi
Copy link
Copy Markdown
Member Author

Closing this since no decision for almost 60 days.

@idvoretskyi idvoretskyi closed this Jan 4, 2018
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 5, 2018

Argh my bad, I meant to open an issue for this. I made noises about removing this to steering@kubernetes.io, and didn't hear a wild no. It's low on my list right now though. I'd like to survey which repos are using collaborators to understand the scope of the role today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants