Skip to content

Optimize route reconciliation logic cherry-pick to 1.25 (#2090)#2140

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.25from
kayrus:optimize-ip-resolve-1.25
Mar 6, 2023
Merged

Optimize route reconciliation logic cherry-pick to 1.25 (#2090)#2140
k8s-ci-robot merged 1 commit intokubernetes:release-1.25from
kayrus:optimize-ip-resolve-1.25

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Mar 3, 2023

What this PR does / why we need it:

Cherry pick of the #2090 to 1.25 release

Which issue this PR fixes(if applicable):

fixes #2089

fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 3, 2023

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2023
@kayrus kayrus changed the title Optimize route reconciliation logic (#2090) Optimize route reconciliation logic cherry-pick to 1.25 (#2090) Mar 3, 2023
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 3, 2023

@zetaab @jichenjc could you please trigger the tests?

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Mar 3, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2023
@zetaab
Copy link
Copy Markdown
Member

zetaab commented Mar 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 3, 2023

/test openstack-cloud-csi-cinder-e2e-test-release-125

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Mar 6, 2023

@zetaab @jichenjc I don't know why do tests fail, but could you please approve this PR?

@zetaab
Copy link
Copy Markdown
Member

zetaab commented Mar 6, 2023

/override openstack-cloud-csi-manila-e2e-test-release-125
/test openstack-cloud-csi-cinder-e2e-test-release-125

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2023

@zetaab: Overrode contexts on behalf of zetaab: openstack-cloud-csi-manila-e2e-test-release-125

Details

In response to this:

/override openstack-cloud-csi-manila-e2e-test-release-125
/test openstack-cloud-csi-cinder-e2e-test-release-125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zetaab
Copy link
Copy Markdown
Member

zetaab commented Mar 6, 2023

/override openstack-cloud-csi-cinder-e2e-test-release-125

this should not change the logic of csi cinder

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2023

@zetaab: Overrode contexts on behalf of zetaab: openstack-cloud-csi-cinder-e2e-test-release-125

Details

In response to this:

/override openstack-cloud-csi-cinder-e2e-test-release-125

this should not change the logic of csi cinder

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 389de0a into kubernetes:release-1.25 Mar 6, 2023
@kayrus kayrus deleted the optimize-ip-resolve-1.25 branch March 6, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@zetaab zetaab

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kayrus @k8s-ci-robot @jichenjc @zetaab