This honestly looks great! Were you thinking that ksync init --psp would require use of the --upgrade flag as well? Also, any harm to just adding the PSP to the init by default for green field installs?

• One suggestion might be add a check to doctor as well, but that's a stretch goal I think.

Thanks for the hard work!

Fixes #341

Thanks.

1. The way that it is written it should work with and without the -u flag.

2. The reasons not to create PSP by default are:
   A. It add some complication and it seems that most environments it is not needed (as evident by the fact that I probably the first one to complain)
   B. Some people may like to more carefully edit the PSPs that they add to their cluster.

Those reasons are not very strong. If you like we can change the default to install PSP.

As for the doctor: as far as I understand the existing doctor checks will identify that something is wrong (the pods are not running) - they won't identify the cause. Identifying the cause will require identifying that the pods cannot be scheduled due to missing PSP - which will probably require looking at the errors events posted on the daemon set. That is indeed a stretch goal and I rather not do it.

@grampelberg: Does changing the default (so that by default PSP is installed) OK with you?

This looks really great to me. The only change I'd make would be to have PSP there always. You're totally right that it isn't required 100% of the time, but for those not using it ... it isn't that big of a deal. It is sane for clusters to be 1.14 or newer, so PSP is pretty much everywhere at this point.

@moshelitvin-MS yup!

Looks good to me too. I totally agree on skipping doctor here.

@mlitvin only thing left is having your commits signed. Once we've got that, this can get merged! See signing commits for more info.