This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Sort resources semantically to tighten up reconciliation#867
Merged
shomron merged 1 commit intoksonnet:masterfrom Sep 20, 2018
Merged
Sort resources semantically to tighten up reconciliation#867shomron merged 1 commit intoksonnet:masterfrom
shomron merged 1 commit intoksonnet:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1347
💛 - Coveralls |
Closes ksonnet#850 Signed-off-by: Oren Shomron <shomron@gmail.com>
2209bed to
8b703db
Compare
underrun
reviewed
Sep 19, 2018
|
|
||
| var kindOrderMap map[string]int | ||
|
|
||
| func init() { |
Collaborator
There was a problem hiding this comment.
instead of having an init - could we use const + iota and just numeric sort?
Collaborator
Author
There was a problem hiding this comment.
How could I lookup the rank in O(1) using that approach?
underrun
approved these changes
Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #850
Signed-off-by: Oren Shomron shomron@gmail.com