Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Upgrade ksonnet-lib printer to avoid double-escaping param values#863

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-861-param-double-escaping
Sep 17, 2018
Merged

Upgrade ksonnet-lib printer to avoid double-escaping param values#863
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-861-param-double-escaping

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Sep 17, 2018

Closes #861

Signed-off-by: Oren Shomron shomron@gmail.com

Closes ksonnet#861

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron force-pushed the issue-861-param-double-escaping branch from 9d4dba5 to a6c898b Compare September 17, 2018 15:51
@shomron shomron requested a review from a team September 17, 2018 15:53
@coveralls
Copy link

coveralls commented Sep 17, 2018

Pull Request Test Coverage Report for Build 1337

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 70.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/params/ext_vars.go 1 3 33.33%
Totals Coverage Status
Change from base Build 1335: 0.2%
Covered Lines: 12545
Relevant Lines: 17794

💛 - Coveralls

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shomron shomron merged commit 2500f08 into ksonnet:master Sep 17, 2018
@shomron shomron deleted the issue-861-param-double-escaping branch September 17, 2018 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants