This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Qualify libraries and refactor app#855
Merged
shomron merged 5 commits intoksonnet:masterfrom Sep 11, 2018
Merged
Conversation
7f6bd26 to
9600bc7
Compare
9600bc7 to
0e621d5
Compare
Pull Request Test Coverage Report for Build 1331
💛 - Coveralls |
Closes ksonnet#617 Signed-off-by: Oren Shomron <shomron@gmail.com>
0e621d5 to
2c3cd5f
Compare
underrun
reviewed
Sep 7, 2018
| if os.IsNotExist(err) { | ||
| // During `ks init`, app.yaml will not yet exist - generate a new one. | ||
| return NewApp010(fs, appRoot, httpClient), nil | ||
| return NewBaseApp(fs, appRoot, httpClient), nil |
Collaborator
There was a problem hiding this comment.
could mock / override NewBaseApp to get some test coverage on app.Load() - not blocking just wanted to note it for future.
bryanl
reviewed
Sep 10, 2018
Member
bryanl
left a comment
There was a problem hiding this comment.
Looking further, there are multiple cases of libaryConfig* types unused.
underrun
reviewed
Sep 10, 2018
| Name: "test-migration", | ||
| Version: "0.0.1", | ||
| Description: "test migration description", | ||
| Authors: []string{ |
Collaborator
There was a problem hiding this comment.
can't approve of these test cases hard enough
20f0959 to
b675f9c
Compare
* Dropped support for 0.0.1 apps * Versioning has been pushed up into the Schema types instead of App. * Added migrations framework for migrating schema versions, one hop at time Closes ksonnet#849 Signed-off-by: Oren Shomron <shomron@gmail.com>
* baseApp.load() / baseApp.save() are override-aware * app.read() / app.write() (schema.go) are not - they only serialize/deserialize app.yaml * baseApp.load() / baseApp.save() now call app.read() / app.write() instead of duplicating serialization logic * Removed isOverride flag from EnvironmentConfig, RegistryConfig * Removed override logic from app.Load() - this is handled in baseApp.load() now * env set command now respects the --override flag to indicate where to write changes Closes ksonnet#830 Signed-off-by: Oren Shomron <shomron@gmail.com>
* Fix panic in migrateSchema010To020, migrateSchema020To030 * Remove unused optLoadFn * Include library qualifying conversions in 030 migration Signed-off-by: Oren Shomron <shomron@gmail.com>
Signed-off-by: Oren Shomron <shomron@gmail.com>
a36108e to
2d58dd5
Compare
bryanl
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor schema to support explicit migrations