This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Merged
Conversation
Pull Request Test Coverage Report for Build 1306
💛 - Coveralls |
shomron
approved these changes
Aug 30, 2018
Collaborator
shomron
left a comment
There was a problem hiding this comment.
Looks good, can we get a squash please?
Collaborator
|
@underrun can you verify if you're using the latest dep release? It looks like there are differences in the lock file that may be related to that. |
to use @shomron's fork via dep source magic Signed-off-by: Derek Wilson <derek@heptio.com>
823ad18 to
d175225
Compare
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to use @shomron's fork via dep source magic
this will allow us to keep the imports as spf13 rather than using forks for a bunch of dependent packages.
also blocks #756
Signed-off-by: Derek Wilson derek@heptio.com