This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Fix sourcePath for imported json on root module#844
Merged
GuessWhoSamFoo merged 1 commit intoksonnet:masterfrom Sep 4, 2018
Merged
Fix sourcePath for imported json on root module#844GuessWhoSamFoo merged 1 commit intoksonnet:masterfrom
GuessWhoSamFoo merged 1 commit intoksonnet:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1309
💛 - Coveralls |
underrun
reviewed
Sep 4, 2018
Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
2b142d2 to
42e7986
Compare
underrun
approved these changes
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the extra
/added because the default module is/since 0.11Added test to hit the code path on https://github.com/ksonnet/ksonnet/blob/master/pkg/actions/import.go#L203
Signed-off-by: GuessWhoSamFoo sfoohei@gmail.com