Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Helm client caches chart configuration to avoid multiple back-to-back downloads#841

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-598-helm-caching
Aug 23, 2018
Merged

Helm client caches chart configuration to avoid multiple back-to-back downloads#841
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-598-helm-caching

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 23, 2018

Closes #598

Signed-off-by: Oren Shomron shomron@gmail.com

… downloads.

Closes ksonnet#598

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron requested a review from a team August 23, 2018 18:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1297

  • 25 of 36 (69.44%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 70.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/registry/manager.go 0 1 0.0%
pkg/registry/helm.go 10 12 83.33%
pkg/helm/caching_client.go 13 21 61.9%
Files with Coverage Reduction New Missed Lines %
pkg/registry/helm.go 1 73.15%
Totals Coverage Status
Change from base Build 1296: -0.007%
Covered Lines: 12300
Relevant Lines: 17437

💛 - Coveralls

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shomron shomron merged commit 08d04fe into ksonnet:master Aug 23, 2018
@shomron shomron deleted the issue-598-helm-caching branch August 23, 2018 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants