Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Garbage collection for vendored packages#837

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-624-garbage-collection
Aug 21, 2018
Merged

Garbage collection for vendored packages#837
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-624-garbage-collection

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 21, 2018

Packages are candidates for removal when they are no longer referenced by either a specific environment or the global scope.

Closes #624

Signed-off-by: Oren Shomron shomron@gmail.com

Packages are candidates for removal when they are no longer referenced by either a specific environment or the global scope.

Closes ksonnet#624

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron requested a review from a team August 21, 2018 19:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1295

  • 74 of 196 (37.76%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 70.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/pkg_describe.go 3 5 60.0%
pkg/pkg/pkg.go 11 13 84.62%
pkg/pkg/local.go 0 5 0.0%
pkg/actions/pkg_install.go 4 11 36.36%
pkg/pkg/helm.go 0 9 0.0%
pkg/actions/pkg_remove.go 3 13 23.08%
pkg/app/schema.go 0 13 0.0%
pkg/pkg/name.go 9 22 40.91%
pkg/registry/package_manager.go 1 24 4.17%
pkg/registry/gc.go 43 81 53.09%
Files with Coverage Reduction New Missed Lines %
pkg/actions/pkg_remove.go 1 50.0%
Totals Coverage Status
Change from base Build 1294: -0.4%
Covered Lines: 12285
Relevant Lines: 17414

💛 - Coveralls

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shomron shomron merged commit 9a3112e into ksonnet:master Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants