Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Validate environment prior to fetching package#835

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-702-validate-env
Aug 20, 2018
Merged

Validate environment prior to fetching package#835
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-702-validate-env

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 20, 2018

Avoid orphaning vendored packages by validating environments prior to installation.

Closes #702

Signed-off-by: Oren Shomron shomron@gmail.com

Exercising the fix 🏋️

ks pkg install --env foo incubator/nginx
ERROR checking environment: environment "foo" was not found 👍

ks pkg install --env default incubator/nginx
INFO Retrieved 7 files

ks pkg install incubator/nginx

@shomron shomron force-pushed the issue-702-validate-env branch from 949053b to ed1a2d1 Compare August 20, 2018 14:11
@shomron shomron requested a review from a team August 20, 2018 14:11
@coveralls
Copy link

coveralls commented Aug 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1293

  • 6 of 15 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 70.937%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/pkg_install.go 6 15 40.0%
Totals Coverage Status
Change from base Build 1292: -0.03%
Covered Lines: 12226
Relevant Lines: 17235
💛 - Coveralls

@shomron
Validate environment prior to fetching in pkg install
abe8e31 
Closes ksonnet#702

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron force-pushed the issue-702-validate-env branch from ed1a2d1 to abe8e31 Compare August 20, 2018 14:26
@shomron shomron merged commit 200abf0 into ksonnet:master Aug 20, 2018
@shomron shomron deleted the issue-702-validate-env branch August 20, 2018 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bryanl bryanl bryanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate environment prior to fetching package

3 participants

@shomron @coveralls @bryanl