Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Add pkg remove command.#834

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-625-pkg-remove
Aug 20, 2018
Merged

Add pkg remove command.#834
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-625-pkg-remove

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 17, 2018

Removes package references from either global or environment scope.
Garbage collection for orphaned packages will be implemented separately.

Closes #625

@shomron shomron requested a review from a team August 17, 2018 20:45
@coveralls
Copy link

coveralls commented Aug 17, 2018

Pull Request Test Coverage Report for Build 1289

  • 76 of 99 (76.77%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.964%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/app/base_app.go 23 31 74.19%
pkg/actions/pkg_remove.go 22 37 59.46%
Files with Coverage Reduction New Missed Lines %
pkg/actions/pkg_install.go 1 63.79%
pkg/app/base_app.go 1 75.07%
Totals Coverage Status
Change from base Build 1287: 0.03%
Covered Lines: 12220
Relevant Lines: 17220

💛 - Coveralls

Removes package references from either global or environment scope.
Garbage collection for orphaned packages will be implemented separately.

Closes ksonnet#625

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron force-pushed the issue-625-pkg-remove branch from 69c414d to ddc51e0 Compare August 20, 2018 00:51
Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shomron shomron merged commit 7093591 into ksonnet:master Aug 20, 2018
@shomron shomron deleted the issue-625-pkg-remove branch August 20, 2018 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants