Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Allow reuse of installed packages in other scopes#833

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-728
Aug 16, 2018
Merged

Allow reuse of installed packages in other scopes#833
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-728

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 15, 2018

Closes #728

Signed-off-by: Oren Shomron shomron@gmail.com

@shomron
Copy link
Collaborator Author

shomron commented Aug 15, 2018

When installing a package that already exists into a scope (env or global) - it will now reference the previously vendored files and not require a --force flag. If --force is provided, the files will always be re-vendored.

@shomron shomron requested a review from a team August 15, 2018 22:44
@coveralls
Copy link

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 1286

  • 9 of 20 (45.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 70.938%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/registry/cache.go 7 18 38.89%
Totals Coverage Status
Change from base Build 1285: -0.02%
Covered Lines: 12156
Relevant Lines: 17136

💛 - Coveralls

When installing a package that already exists into a scope (env or global) -
it will now reference the previously vendored files and not require a --force flag.
If --force is provided, the files will always be re-vendored.

Closes ksonnet#728

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron merged commit 025a319 into ksonnet:master Aug 16, 2018
@shomron shomron deleted the issue-728 branch August 16, 2018 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants