Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Allow showing only env set parameters#817

Merged
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:747-list-environment-parameters
Aug 6, 2018
Merged

Allow showing only env set parameters#817
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:747-list-environment-parameters

Conversation

@bryanl
Copy link
Member

@bryanl bryanl commented Aug 6, 2018

When listing parameters for an environment, add an option that only
shows parameters set in the environment itself. This will allow ks users
to show only the differences. The new option is --without-modules.

example:

 $ ks param list --env default
COMPONENT     PARAM   VALUE
=========     =====   =====
nested.redis3 envset  1
redis         envset  1
redis2        envset  1
redis2        name    'redis2'
redis2        values  {}
redis2        version '3.7.3'
$ ks param list --env default --without-modules
COMPONENT     PARAM  VALUE
=========     =====  =====
nested.redis3 envset 1
redis         envset 1
redis2        envset 1

Fixes #747

@coveralls
Copy link

coveralls commented Aug 6, 2018

Pull Request Test Coverage Report for Build 1269

  • 45 of 50 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 70.984%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/pipeline/pipeline.go 29 34 85.29%
Totals Coverage Status
Change from base Build 1266: 0.04%
Covered Lines: 12046
Relevant Lines: 16970

💛 - Coveralls

@bryanl bryanl requested a review from a team August 6, 2018 13:02
@bryanl bryanl added the wip work in progress label Aug 6, 2018
@bryanl
Copy link
Member Author

bryanl commented Aug 6, 2018

I'm going to take a deeper look at this. The module structure might have to be replicated internally rather than returning a {}.

When listing parameters for an environment, add an option that only
shows parameters set in the environment itself. This will allow ks users
to show only the differences. The new option is `--without-modules`.

example:

```
 $ ks param list --env default
COMPONENT     PARAM   VALUE
=========     =====   =====
nested.redis3 envset  1
redis         envset  1
redis2        envset  1
redis2        name    'redis2'
redis2        values  {}
redis2        version '3.7.3'
$ ks param list --env default --without-modules
COMPONENT     PARAM  VALUE
=========     =====  =====
nested.redis3 envset 1
redis         envset 1
redis2        envset 1
```

Fixes ksonnet#747

Signed-off-by: bryanl <bryanliles@gmail.com>
@bryanl bryanl force-pushed the 747-list-environment-parameters branch from 0ffd3e6 to 49a682d Compare August 6, 2018 14:17
@bryanl bryanl removed the wip work in progress label Aug 6, 2018
@bryanl bryanl merged commit c15cffb into ksonnet:master Aug 6, 2018
@bryanl bryanl deleted the 747-list-environment-parameters branch August 6, 2018 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants