This repository was archived by the owner on Sep 9, 2020. It is now read-only.
ks diff support for objects outside of the "all" category#811
Merged
shomron merged 1 commit intoksonnet:masterfrom Aug 2, 2018
Merged
ks diff support for objects outside of the "all" category#811shomron merged 1 commit intoksonnet:masterfrom
shomron merged 1 commit intoksonnet:masterfrom
Conversation
This PR allows ks diff to consider objects that are not part of the "all" category, e.g. Ingress, Certificate. Additionally, the cluster settings of the environment being diffed are respected and override the current context when deciding where to connect. Fixes ksonnet#803 Fixes ksonnet#809 Signed-off-by: Oren Shomron <shomron@gmail.com>
Pull Request Test Coverage Report for Build 1260
💛 - Coveralls |
bryanl
approved these changes
Aug 2, 2018
Member
bryanl
left a comment
There was a problem hiding this comment.
LGTM
this is a good improvement around diff
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows ks diff to consider objects that are not part of the
"all" category, e.g. Ingress, Certificate.
Additionally, the cluster settings of the environment being diffed are
respected and override the current context when deciding where to
connect.
Fixes #803
Fixes #809
Signed-off-by: Oren Shomron shomron@gmail.com