Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Sort objects prior to diff#808

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-801-ks-diff-sort
Aug 2, 2018
Merged

Sort objects prior to diff#808
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-801-ks-diff-sort

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Aug 1, 2018

Additional fixes:

  • sort order is constant for json and yaml output of ks show

Fixes #801

Signed-off-by: Oren Shomron shomron@gmail.com

Additional fixes:

  * sort order is constant for json and yaml output of `ks show`

Fixes ksonnet#801

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron requested a review from bryanl August 1, 2018 18:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1257

  • 50 of 67 (74.63%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 71.34%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/diff/diff.go 10 16 62.5%
pkg/cluster/sort.go 32 43 74.42%
Files with Coverage Reduction New Missed Lines %
pkg/diff/diff.go 1 76.53%
Totals Coverage Status
Change from base Build 1254: -0.05%
Covered Lines: 12040
Relevant Lines: 16877

💛 - Coveralls

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shomron shomron merged commit f10518e into ksonnet:master Aug 2, 2018
@shomron shomron deleted the issue-801-ks-diff-sort branch August 2, 2018 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diff results are order-dependent

3 participants