Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Upgrade go-jsonnet to 0.11.2#800

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-783-upgrade-go-jsonnet
Jul 30, 2018
Merged

Upgrade go-jsonnet to 0.11.2#800
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-783-upgrade-go-jsonnet

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Jul 30, 2018

Fixes #783

Signed-off-by: Oren Shomron shomron@gmail.com

Fixes ksonnet#783

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron requested a review from bryanl July 30, 2018 17:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 144 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 71.07%

Files with Coverage Reduction New Missed Lines %
pkg/component/delete.go 20 68.42%
pkg/component/jsonnet.go 26 75.2%
pkg/component/component.go 36 15.63%
pkg/component/yaml.go 62 71.76%
Totals Coverage Status
Change from base Build 1247: -0.1%
Covered Lines: 11971
Relevant Lines: 16844

💛 - Coveralls

@shomron
Copy link
Collaborator Author

shomron commented Jul 30, 2018

@bryanl I am unclear on why the cobra files were deleted.
My process was:

  • Upgrade go-jsonnet revision in Gopkg.toml
  • Run dep ensure

I also started with a clean vendor directory with the same result.
dep version is v0.5.0.

@bryanl
Copy link
Member

bryanl commented Jul 30, 2018

That's interesting. I'll try a dep ensure locally too

@shomron shomron merged commit 50db056 into ksonnet:master Jul 30, 2018
@shomron shomron deleted the issue-783-upgrade-go-jsonnet branch July 30, 2018 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants