This repository was archived by the owner on Sep 9, 2020. It is now read-only.
ks component list aggregates from all modules#797
Merged
shomron merged 1 commit intoksonnet:masterfrom Jul 30, 2018
Merged
Conversation
Pull Request Test Coverage Report for Build 1253
💛 - Coveralls |
Member
|
@shomron There are no plans to remove |
bryanl
reviewed
Jul 30, 2018
pkg/pipeline/pipeline.go
Outdated
| components := make([]component.Component, 0) | ||
| for _, ns := range modules { | ||
| members, err := p.cm.Components(ns) | ||
| members, err := p.cm.Components(p.app, ns.Name()) |
Member
There was a problem hiding this comment.
module used to be named namespace. That was changed for reasons, but there are still a bunch of ns littered through the code base. Would you mind cleaning up the ones in this PR?
Fixes ksonnet#765 Signed-off-by: Oren Shomron <shomron@gmail.com>
dd7d259 to
6983dd2
Compare
Collaborator
Author
I wasn't planning on it - filtering still seems valuable. I'd like to think in future about consolidating all our filters under a shared |
bryanl
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #765
Signed-off-by: Oren Shomron shomron@gmail.com