Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

ks upgrade canonicalizes environment target separators (/ -> .)#792

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-766-canonical-env-targets
Jul 30, 2018
Merged

ks upgrade canonicalizes environment target separators (/ -> .)#792
shomron merged 1 commit intoksonnet:masterfrom
shomron:issue-766-canonical-env-targets

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Jul 26, 2018

Fixes #766

Signed-off-by: Oren Shomron shomron@gmail.com

@shomron shomron requested a review from a team July 26, 2018 20:08
@coveralls
Copy link

coveralls commented Jul 26, 2018

Pull Request Test Coverage Report for Build 1246

  • 26 of 38 (68.42%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 71.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/app/app010.go 0 3 0.0%
pkg/upgrade/upgrade010.go 26 35 74.29%
Totals Coverage Status
Change from base Build 1245: -0.006%
Covered Lines: 11974
Relevant Lines: 16818

💛 - Coveralls

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes ksonnet#766

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron force-pushed the issue-766-canonical-env-targets branch from 750979a to 00268fa Compare July 30, 2018 13:20
@shomron shomron merged commit 230769d into ksonnet:master Jul 30, 2018
@shomron shomron deleted the issue-766-canonical-env-targets branch July 30, 2018 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants