This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Get a new version of the object when retrying on conflict#787
Merged
bryanl merged 1 commit intoksonnet:masterfrom Jul 25, 2018
Merged
Get a new version of the object when retrying on conflict#787bryanl merged 1 commit intoksonnet:masterfrom
bryanl merged 1 commit intoksonnet:masterfrom
Conversation
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
Pull Request Test Coverage Report for Build 1235
💛 - Coveralls |
bryanl
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is necessary to update the resource version if retrying an update due to a conflict. Otherwise, the code retries with the same resource version and will get another 409 back from Kubernetes.
Fixes #650
Signed-off-by: Chris Marchbanks csmarchbanks@gmail.com