Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

fix verbose error message in generate cli#772

Merged
bryanl merged 1 commit intoksonnet:masterfrom
nicholas-fwang:master
Jul 29, 2018
Merged

fix verbose error message in generate cli#772
bryanl merged 1 commit intoksonnet:masterfrom
nicholas-fwang:master

Conversation

@nicholas-fwang
Copy link
Contributor

When use ks generate

$ ks generate --help
...
Global Flags:
  -v, --verbose count[=-1]   Increase verbosity. May be given multiple times.

if use ks generate with --verbose(or -v), we meet error msg

$ ks generate deployed-service guestbook-ui   \
--image gcr.io/heptio-images/ks-guestbook-demo:0.1  \
--type ClusterIP \
--verbose=-1

unknown flag: --verbose
Usage of prototype-flags:
--containerPort string Container port for service to target. (default "80")
--image string Container image to deploy
--module string Component module
--name string Name of the service and deployment resources
--replicas string Number of replicas (default "1")
--servicePort string Port for the service to expose. (default "80")
--type string Type of service to expose (default "ClusterIP")
--values-file string Prototype values file (file returns a Jsonnet object)
ERROR parse preview args: unknown flag: --verbose

Actually, present ks generate command doesn't send any debug msg, however verbose flag is gobal option, then we could use it in any command.

then, I added verbose to prototype-flags.

@nicholas-fwang nicholas-fwang force-pushed the master branch 2 times, most recently from d751c9b to 32725db Compare July 18, 2018 17:27
Signed-off-by: Inki Hwang <hwang031451@gmail.com>
@coveralls
Copy link

coveralls commented Jul 18, 2018

Pull Request Test Coverage Report for Build 1233

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 71.199%

Totals Coverage Status
Change from base Build 1229: 0.002%
Covered Lines: 11940
Relevant Lines: 16770

💛 - Coveralls

@bryanl bryanl added the bug label Jul 20, 2018
@bryanl bryanl merged commit 5be3b2d into ksonnet:master Jul 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants