This repository was archived by the owner on Sep 9, 2020. It is now read-only.
All user to force install package with --force#744
Merged
bryanl merged 1 commit intoksonnet:masterfrom Jul 13, 2018
Merged
Conversation
This feature is added to allow two versions of a package to be installed. (e.g. having multiple versions of a helm chart installed) Signed-off-by: bryanl <bryanliles@gmail.com>
Pull Request Test Coverage Report for Build 1190
💛 - Coveralls |
| if ok { | ||
| if ok && !force { | ||
| return nil, errors.Errorf("package '%s/%s@%s' already exists.", | ||
| libRef.Registry, libRef.Name, libRef.Version) |
Collaborator
There was a problem hiding this comment.
libRef.Version returns "" rather than SemVer; might be confusing later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is added to allow two versions of a package to be
installed. (e.g. having multiple versions of a helm chart installed)
cc: @GuessWhoSamFoo
Signed-off-by: bryanl bryanliles@gmail.com