Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Allow installing packages into environment scope#697

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:package-install-env
Jul 6, 2018
Merged

Allow installing packages into environment scope#697
shomron merged 1 commit intoksonnet:masterfrom
shomron:package-install-env

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Jul 5, 2018 •
edited
Loading

  • Add --env flag to pkg install cli
  • Add support for environment qualifier in app.UpdateLib()
  • Refactor CacheDependency to only focus on vendoring, app update is handled by the caller
  • Move default app.Environment[s] implementation to baseApp.

Signed-off-by: Oren Shomron shomron@gmail.com

@shomron
Copy link
Collaborator Author

shomron commented Jul 5, 2018

Feature exercised in https://gist.github.com/shomron/828e3efa01039b80e3c23ca0b153eded

@shomron shomron force-pushed the package-install-env branch from 9096f8c to 4c453ec Compare July 5, 2018 18:51
@coveralls
Copy link

coveralls commented Jul 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1142

  • 49 of 79 (62.03%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 70.898%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/pkg_install.go 8 12 66.67%
pkg/registry/cache.go 2 13 15.38%
pkg/app/base_app.go 36 51 70.59%
Totals Coverage Status
Change from base Build 1141: 0.04%
Covered Lines: 11482
Relevant Lines: 16195
💛 - Coveralls

@shomron shomron force-pushed the package-install-env branch from 4c453ec to b608256 Compare July 5, 2018 20:15
bryanl
bryanl reviewed Jul 5, 2018
View reviewed changes
Copy link
Member

@bryanl bryanl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial notes:

  • If you install a package into an invalid environment, it still downloads to vendor. Is this wanted feature?
  • ks pkg list doesn't know about packages installed in an environment.

bryanl
bryanl previously requested changes Jul 5, 2018
View reviewed changes
Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss my initial notes...

@bryanl bryanl dismissed their stale review July 5, 2018 23:12

premature. It isn't rejected as I'm not sure if it is complete.

@bryanl bryanl added this to the 0.12.0 milestone Jul 5, 2018
@shomron
Copy link
Collaborator Author

shomron commented Jul 6, 2018

@bryanl thanks for looking at this.

Regarding the initial notes:

@shomron
Allow installing packages into environment scope
826c805 
* Add --env flag to pkg install cli
* Add support for environment qualifier in app.UpdateLib()
* Refactor CacheDependency to only focus on vendoring, app update is handled by the caller
* Move default app.Environment[s]() implementation to baseApp.

Closes ksonnet#688

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron shomron force-pushed the package-install-env branch from b608256 to 826c805 Compare July 6, 2018 14:46
@shomron
Copy link
Collaborator Author

shomron commented Jul 6, 2018

Rebased before merge.

@shomron shomron merged commit 6b6f45e into ksonnet:master Jul 6, 2018
@shomron
Copy link
Collaborator Author

shomron commented Jul 6, 2018

Closes #688

@shomron shomron mentioned this pull request Jul 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bryanl bryanl bryanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shomron @coveralls @bryanl